-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TFormula::Eval() to reduce code duplication #7804
Refactor TFormula::Eval() to reduce code duplication #7804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, looks good !
Thank you for your contribution!
641acd0
to
ab71ecd
Compare
@phsft-bot build |
Starting build on |
Build failed on windows10/default. Errors:
|
This PR aims to reduce code duplication in
TFormula
class by replacing 4 overloadedEval
functions by one variadic template function.We can also add an extra check to ensure all arguments passed to the template function are of arithmetic type. Please tell if I should add this extra check.