Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TFormula::Eval() to reduce code duplication #7804

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

parth-07
Copy link
Contributor

@parth-07 parth-07 commented Apr 8, 2021

This PR aims to reduce code duplication in TFormula class by replacing 4 overloaded Eval functions by one variadic template function.
We can also add an extra check to ensure all arguments passed to the template function are of arithmetic type. Please tell if I should add this extra check.

@parth-07 parth-07 requested a review from lmoneta as a code owner April 8, 2021 16:16
@lmoneta lmoneta self-assigned this Apr 9, 2021
Copy link
Member

@lmoneta lmoneta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, looks good !
Thank you for your contribution!

@bellenot
Copy link
Member

@parth-07 please fork also roottest to prevent timeout on the Windows build nodes

@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from lmoneta Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from lmoneta Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from parth-07 Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from lmoneta Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from phsft-bot Oct 14, 2023
@root-project root-project deleted a comment from bellenot Oct 14, 2023
@guitargeek guitargeek force-pushed the refactor-tformula-eval branch from 641acd0 to ab71ecd Compare October 14, 2023 09:11
@guitargeek
Copy link
Contributor

@phsft-bot build

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2023-10-14T09:47:19.627Z] C:\build\workspace\root-pullrequests-build\root\core\imt\src\TTaskGroup.cxx(18,10): fatal error C1083: Cannot open include file: 'tbb/task_group.h': No such file or directory [C:\build\workspace\root-pullrequests-build\build\core\imt\Imt.vcxproj]
  • [2023-10-14T09:47:19.910Z] C:\build\workspace\root-pullrequests-build\root\core\imt\src\ROpaqueTaskArena.hxx(1,10): fatal error C1083: Cannot open include file: 'tbb/task_arena.h': No such file or directory [C:\build\workspace\root-pullrequests-build\build\core\imt\Imt.vcxproj]
  • [2023-10-14T09:47:21.070Z] C:\build\workspace\root-pullrequests-build\root\core\imt\src\ROpaqueTaskArena.hxx(1,10): fatal error C1083: Cannot open include file: 'tbb/task_arena.h': No such file or directory [C:\build\workspace\root-pullrequests-build\build\core\imt\Imt.vcxproj]

@github-actions
Copy link

Test Results

       12 files         12 suites   2d 1h 7m 29s ⏱️
  2 483 tests   2 481 ✔️ 0 💤 2
28 680 runs  28 676 ✔️ 0 💤 4

For more details on these failures, see this check.

Results for commit ab71ecd.

@guitargeek guitargeek merged commit 9e82068 into root-project:master Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants